Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix schema #12

wants to merge 4 commits into from

Conversation

krisselden
Copy link

@krisselden krisselden commented Aug 3, 2018

Fixes a number of issues that cause problems when using the schema with other tools, like generating typescript interfaces or validation.

@chasetec
Copy link

Hi @ahmadnassri

Is anything blocking this? The invalid keywords prevent using strict mode with ajv. If you run with:

        var ajv = new Ajv({
            strict: "log"
        });

You'll see:

strict mode: unknown keyword: "optional"
strict mode: unknown keyword: "unique"
strict mode: unknown keyword: "unique"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "optional"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "optional"
strict mode: missing type "object" for keyword "required" at "request.jsonpostData.json#/properties/params" (strictTypes) 
strict mode: missing type "object" for keyword "properties" at "request.jsonpostData.json#/properties/params" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "cache.json#" (strictTypes)
strict mode: unknown keyword: "optional"
strict mode: unknown keyword: "optional"
strict mode: missing type "object" for keyword "required" at "entry.jsontimings.json#" (strictTypes)
strict mode: missing type "object" for keyword "properties" at "entry.jsontimings.json#" (strictTypes)
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"
strict mode: unknown keyword: "min"

@nsrCodes
Copy link

@ahmadnassri is there something preventing fixes like these to get merged? I am inclined to solve a problem in an upstream package that stems from here, but just wanted to confirm if changes are still being accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants