-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for the free-threaded build of CPython 3.13 #84
base: master
Are you sure you want to change the base?
Conversation
@@ -1,4 +1,4 @@ | |||
# cython: language_level=3 | |||
# cython: language_level=3, freethreading_compatible=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can go into pyproject.toml
. There's a section for Cython.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that but it unfortunately cannot, because there's not the ability to add a version-specific option to pyproject.toml. For this, the build backend would have to be changed, which seems like a bigger hassle.
Hey folks, thanks for all the review and sorry for the extended delay here, I was out on PTO. I've addressed most of the comments around adding some TODOs and replied to the rest. |
CodSpeed Performance ReportMerging #84 will degrade performances by 7.82%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 18 18
Lines 738 739 +1
Branches 75 75
==========================================
+ Hits 657 658 +1
Misses 63 63
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What do these changes do?
Are there changes in behavior for the user?
No.
Related issue number
Checklist