-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RGBW LEDs like SK6812RGBW #143
base: master
Are you sure you want to change the base?
Changes from all commits
d6860e6
be64cb5
7afb78a
0ea7fea
e00bbcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
node_modules | ||
.vscode |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajfisher I have made some protections within pixel.js to make sure that by default, we send an array with length of 3. We send 4 if rgbw colors are declared at instantiation. I'm going to work on adding similar protection here I think, to make sure all is good within the firmware.I wanted your feedback on this approach so far before I get too into it. Please let me know your thoughts on what I have in the PR to this point. I will also go back and make sure all tests pass within the next few days. Thanks!