Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app ping retry interval #2122

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix: app ping retry interval #2122

merged 1 commit into from
Sep 29, 2024

Conversation

manuel-rw
Copy link
Collaborator

Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (Please specify!)

Overview

Briefly outline your new changes...

Issue Number (if applicable)

Related issue: #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency please outline here.

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot.

Copy link

github-actions bot commented Sep 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 17.22% 5620 / 32626
🔵 Statements 17.22% 5620 / 32626
🔵 Functions 6.37% 33 / 518
🔵 Branches 37.22% 134 / 360
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Dashboard/Tiles/Apps/AppPing.tsx 28.48% 100% 0% 28.48% 16-57, 65-74, 77-81, 91-97, 100-136, 149-165
Generated in workflow #6871

@manuel-rw manuel-rw force-pushed the fix/app-ping-retry-interval branch from 31a483d to 993739a Compare September 4, 2024 18:48
@manuel-rw manuel-rw linked an issue Sep 29, 2024 that may be closed by this pull request
4 tasks
@manuel-rw manuel-rw marked this pull request as ready for review September 29, 2024 12:19
@manuel-rw manuel-rw self-assigned this Sep 29, 2024
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuel-rw manuel-rw merged commit 4bba516 into dev Sep 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pings for offline devices not showing correctly
2 participants