Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a popup on start trial #1116

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Mar 26, 2025

closes #826

@jzsfkzm jzsfkzm requested a review from a team as a code owner March 26, 2025 11:43
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 9.89%. Comparing base (3a6b2b9) to head (a4877f3).

Files with missing lines Patch % Lines
...-web/src/components/layout/WelcomeToTrialModal.tsx 30.43% 16 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #1116      +/-   ##
=========================================
- Coverage   12.35%   9.89%   -2.46%     
=========================================
  Files         450     438      -12     
  Lines       12108   11700     -408     
  Branches     2565    2499      -66     
=========================================
- Hits         1496    1158     -338     
- Misses      10033   10364     +331     
+ Partials      579     178     -401     
Flag Coverage Δ
deploy-web 9.89% <33.33%> (+0.04%) ⬆️
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This should be displayed anywhere in the app, not just get started section.

@jzsfkzm jzsfkzm force-pushed the feature/trial-success-popup branch from 680f9f0 to 71df79d Compare March 26, 2025 20:01
@jzsfkzm
Copy link
Contributor Author

jzsfkzm commented Mar 26, 2025

Nice! This should be displayed anywhere in the app, not just get started section.

Thanks! Ah, ok, added to layout now.
Screenshot 2025-03-26 at 21 02 06

Comment on lines +58 to +61
You&apos;re all set to start deploying your first service. During your trial, you can create and manage up to 5 deployments — perfect for
exploring everything our platform has to offer.
</p>
<p>Get started now and see what you can build!</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anilmurty Can you validate this copy please?

@jzsfkzm jzsfkzm force-pushed the feature/trial-success-popup branch from 71df79d to a4877f3 Compare March 27, 2025 07:59
@baktun14 baktun14 merged commit fdee6e6 into akash-network:main Mar 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start trial success popup
3 participants