Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): show banner for trial users with no bids #922

Merged

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Feb 28, 2025

refs #887

@jzsfkzm jzsfkzm requested a review from a team as a code owner February 28, 2025 11:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 24.07407% with 41 lines in your changes missing coverage. Please review.

Project coverage is 24.44%. Comparing base (c8ab4fb) to head (2ad4700).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...-web/src/components/new-deployment/CreateLease.tsx 0.00% 28 Missing ⚠️
...web/src/components/new-deployment/ManifestEdit.tsx 0.00% 5 Missing ⚠️
...pps/deploy-web/src/utils/deploymentData/v1beta3.ts 33.33% 4 Missing ⚠️
...vices/trial-validation/trial-validation.service.ts 76.92% 3 Missing ⚠️
...-web/src/context/WalletProvider/WalletProvider.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (24.07%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #922       +/-   ##
===========================================
+ Coverage   12.35%   24.44%   +12.09%     
===========================================
  Files         450      676      +226     
  Lines       12108    17070     +4962     
  Branches     2572     3251      +679     
===========================================
+ Hits         1496     4173     +2677     
- Misses      10033    12708     +2675     
+ Partials      579      189      -390     
Flag Coverage Δ
api 56.31% <78.57%> (?)
deploy-web 9.83% <5.00%> (-0.02%) ⬇️
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jzsfkzm jzsfkzm force-pushed the feature/zero-bid-warning-for-trials branch 3 times, most recently from c0b5697 to d210784 Compare March 8, 2025 15:05
@jzsfkzm jzsfkzm force-pushed the feature/zero-bid-warning-for-trials branch 5 times, most recently from 3f1a7e9 to 76dd0c4 Compare March 18, 2025 16:02
@jzsfkzm jzsfkzm force-pushed the feature/zero-bid-warning-for-trials branch 2 times, most recently from 216a6c1 to 886788b Compare March 21, 2025 17:38
@jzsfkzm jzsfkzm force-pushed the feature/zero-bid-warning-for-trials branch from 886788b to 374fc2c Compare March 26, 2025 21:13
@baktun14 baktun14 merged commit 344af36 into akash-network:main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants