calendar_base_booking: extend readme, comment cleanup, function rename #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkhao
force-pushed
the
14.0-calendar_base_booking_imp
branch
2 times, most recently
from
ec4c3a8 to
57d43c0
Compare
kevinkhao
force-pushed
the
14.0-calendar_base_booking_imp
branch
from
65c4f45 to
a64f545
Compare
kevinkhao
force-pushed
the
14.0-calendar_base_booking_imp
branch
from
a64f545 to
21bcfc5
Compare
| return slots | ||
|
|
||
| def _get_domain_for_current_object(self): | ||
| def get_booked_slots(self, start=None, stop=None): | ||
| if start and stop: |
There was a problem hiding this comment.
I not sure that it's usefull to have the possibility to not pass a start and stop date ? (for the two other method it's required and I do not see case of use)
sebastienbeau
requested changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.