-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricting the validation area to GB #78
Conversation
Merging changes
I think this is now ready for review. In this PR:
Examples can be seen here: https://wandb.ai/manchester_prize/cropping?nw=nwuserifenton. This has four runs:
They seem to behave as I expect, though given they are only run on five batches I wouldn't place too much weight on the exact results. |
Hi @IFenton, looks good. Before we merge can we check that we get the same validation scores for these runs?
If i understand right, they should have the same scores since they are evaluated on the same GB crop. I think it should be possible to do that by setting the numpy random seed so that the shuffle is reproducible. And also setting number of workers to zero in the validate function so that multiprocessing doesn't cause different samples to be delivered. If that works I'd be happy :) |
I ran that test, and the results of this are in the same WandB link. As you expected they do give identical results |
Great, looks good! |
No description provided.