Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(get_iv; get_all_ivs ): make parameter code handling more general for ivs #10

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ntdosch
Copy link
Contributor

@ntdosch ntdosch commented Mar 31, 2022

Addresses #8 -- Some updates to get_iv() and get_all_ivs() to handle parameter codes in a more general way and added sample_period and agg_method arguments to get_all_ivs(). Added helper function get_par_description() to extract the parameter description from sitefile_text. Parameter description is then used as the header of the data column in the returned DataFrame. Should also note that this PR doesn't touch the dv functions.

Added a few tests to test_nwis.py to make sure changes work properly (test_get_ivs_gw, test_get_ivs_sw, test_get_all_ivs_sw, and test_get_all_ivs_gw)

…codes and pull parameter code descriptions from nwis
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #10 (0774bc0) into develop (8d6dacb) will increase coverage by 0.82%.
The diff coverage is 82.50%.

@@             Coverage Diff             @@
##           develop      #10      +/-   ##
===========================================
+ Coverage    78.19%   79.01%   +0.82%     
===========================================
  Files           11       11              
  Lines          752      810      +58     
===========================================
+ Hits           588      640      +52     
- Misses         164      170       +6     
Impacted Files Coverage Δ
pydrograph/nwis.py 85.12% <73.07%> (-0.89%) ⬇️
pydrograph/tests/test_nwis.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant