-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New and updated Prometheus metrics #3844
Merged
Merged
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5225f54 - Browse repository at this point
Copy the full SHA 5225f54View commit details -
Update collection-related Prometheus metrics
Previously, there was one `aleph_collections` metric with a `category` label. In addition to collection counts by category, we also want to track collection counts by country and languages. In order to keep metric cardinalities under control, I've decided to split the `aleph_collections` metric into three separate metrics: `aleph_collection_categories`, `aleph_collection_countries`, and `aleph_collection_languages`. Each of these metrics has one additional label `type` which can be either `dataset` or `casefile`. This allows to query for the datasets or investigations in a particular language or related to a particular country. I have also removed the `category` label from the `aleph_collection_users` metric as it wasn't that useful.
Configuration menu - View commit details
-
Copy full SHA for da01ce5 - Browse repository at this point
Copy the full SHA da01ce5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9714619 - Browse repository at this point
Copy the full SHA 9714619View commit details -
Configuration menu - View commit details
-
Copy full SHA for b659a20 - Browse repository at this point
Copy the full SHA b659a20View commit details -
Configuration menu - View commit details
-
Copy full SHA for eecde50 - Browse repository at this point
Copy the full SHA eecde50View commit details -
Add
auth_method
label for request-related Prometheus metricsThis allows us to get a better understanding of API requests that originate from the UI and requests from third parties using an API key.
Configuration menu - View commit details
-
Copy full SHA for 35b99b2 - Browse repository at this point
Copy the full SHA 35b99b2View commit details
Commits on Aug 15, 2024
-
Fix phone numbers used in tests
This test started to fail with an upgrade of the `phonenumbers` package (imported via `followthemoney`) which included updated phone number validation rules. As a result, the phone numbers in this test case didn’t pass validation anymore and were cleaned from the entites created. At first glance these numbers seemed to be valid German mobile phone numbers and I was worried that there might be a regression in `phonenumbers`. But according to the International Telecommunication Union, a phone number with the prefix `176` has to be 11 digits long. I adjusted the tests accordingly. https://www.itu.int/oth/T0202000051/en
Configuration menu - View commit details
-
Copy full SHA for 6de774d - Browse repository at this point
Copy the full SHA 6de774dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.