Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: OG ALF token #45

Merged
merged 12 commits into from
Nov 3, 2023
Merged

add: OG ALF token #45

merged 12 commits into from
Nov 3, 2023

Conversation

sven-hash
Copy link
Collaborator

No description provided.

@sven-hash
Copy link
Collaborator Author

@Lbqds could it be possible to set a different name than the one used when deploying the token ?

@h0ngcha0
Copy link
Member

@sven-hash Q: seems that ALF.svg is not used?

@h0ngcha0
Copy link
Member

@Lbqds could it be possible to set a different name than the one used when deploying the token ?

The name has to match the name on-chain, there is a test in this repo to verify this:
https://github.com/alephium/token-list/blob/master/test/token-list/token-list.test.ts#L73-L79

@sven-hash
Copy link
Collaborator Author

@h0ngcha0 yes but it's not possible to have 2 tokens with the same name, let me know what I can do
And yes I can remove ALF.svg

@h0ngcha0
Copy link
Member

@h0ngcha0 yes but it's not possible to have 2 tokens with the same name, let me know what I can do And yes I can remove ALF.svg

Interesting edge case, the newly added token has the same name as an existing one 🤔
@tdroxler WDTY? Does it make sense to e.g. introduce an optional onchain_name which falls back to name and use that to verify against the name in the token contract?

@sven-hash
Copy link
Collaborator Author

I removed the svg file

@tdroxler
Copy link
Member

tdroxler commented Nov 1, 2023

@h0ngcha0 mmm actually as we can have on chain tokens with same name/symbol etc, I guess we can accept them here, we should just modify this test to only check tokenId duplicates

@tdroxler
Copy link
Member

tdroxler commented Nov 2, 2023

hey @sven-hash you can have a look to #46 , I updated the test to allow tokens with same name/symbol, as it's the case on-chain.

I also fix our test since your PR wasn't failing while it should, since your data mismatch the on-chain one.

also I think we now need to change the logo name to the id of the token, it's less readable, but if we have tokens with same symbols, then we won't be able to have different images.

@sven-hash
Copy link
Collaborator Author

@tdroxler seems running great

@tdroxler tdroxler merged commit b792332 into alephium:master Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants