-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: OG ALF token #45
Conversation
@Lbqds could it be possible to set a different name than the one used when deploying the token ? |
@sven-hash Q: seems that |
The name has to match the name on-chain, there is a test in this repo to verify this: |
@h0ngcha0 yes but it's not possible to have 2 tokens with the same name, let me know what I can do |
Interesting edge case, the newly added token has the same name as an existing one 🤔 |
I removed the svg file |
hey @sven-hash you can have a look to #46 , I updated the test to allow tokens with same name/symbol, as it's the case on-chain. I also fix our test since your PR wasn't failing while it should, since your data mismatch the on-chain one. also I think we now need to change the logo name to the id of the token, it's less readable, but if we have tokens with same symbols, then we won't be able to have different images. |
@tdroxler seems running great |
No description provided.