add staticName and defaultValue for MetricOption #7
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: dynamicNamespace if service or stage is loaded from config
ChristopheBougere
requested changes
Jun 24, 2019
There was a problem hiding this comment.
Except for that, looks good to me 👍
Also, the metric name is a breaking change (starts with an capital letter because of normalizeName use), so maybe publish a major release @alex20465?
| Properties: { | ||
| FilterPattern: pattern, | ||
| LogGroupName: logGroupName, | ||
| MetricTransformations: [ | ||
| { | ||
| MetricName: `${functionName}-${name}`, | ||
| MetricName: (staticName) ? name : `${normalizedName}-${name}`, | ||
| MetricNamespace: namespace || dynamicNamespace, |
There was a problem hiding this comment.
should be this.dynamicNamespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add staticName and defaultValue for MetricOption
fix: dynamicNamespace if service or stage is loaded from config
fix: function name is required to be populated from variables.