Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence dropping_references lint. #514

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

ehuss
Copy link
Collaborator

@ehuss ehuss commented Jul 27, 2023

Rust 1.71 added a dropping_references lint which detects a drop() of a reference. This was firing in some default trait functions which were using that to avoid the unused variables lint. The workaround here is to just bind them to a wildcard pattern. An alternate solution would be to add #[allow(unused_variables)]. Another alternate solution would to use _ prefixes, but I assume that isn't desirable since that affects the documentation.

@alexcrichton alexcrichton merged commit ff6ad21 into alexcrichton:main Jul 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants