Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stripe payment by payment link #1310

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

frnd
Copy link

@frnd frnd commented Oct 1, 2022

Adding Stripe payment by link.

The payment link is sent to the user in the booking confirmation email. Stripe payment link can be configured to forward the user to internal confirmation page to track successful payments in the calendar. An email is also sent to the user with the payment confirmation.

Paid booking can be deleted but service can not be modified by the user. Refunds should be handled manually.

  • Add translations to all languages.
  • Document changes
  • Configuration to enable payment feature

@frnd frnd force-pushed the feature/add_payment_by_link branch from a4184fa to abd5027 Compare October 1, 2022 12:55
@kaspernowak
Copy link

I can help with Danish translation. How can I contribute?

@frnd
Copy link
Author

frnd commented Oct 10, 2022

I can help with Danish translation. How can I contribute?

Thanks for your interest. I'm still working on it. I will add all new labels to all translation files with the text in English. Maybe you can create a follow up MR when this one is merged. What do you think?

@kaspernowak
Copy link

I can help with Danish translation. How can I contribute?

Thanks for your interest. I'm still working on it. I will add all new labels to all translation files with the text in English. Maybe you can create a follow up MR when this one is merged. What do you think?

Ahh, I get it. Sure, I can do that :)

@frnd frnd force-pushed the feature/add_payment_by_link branch 4 times, most recently from 41e436a to 371678a Compare October 29, 2022 16:53
@frnd frnd marked this pull request as ready for review October 29, 2022 16:55
@frnd frnd force-pushed the feature/add_payment_by_link branch from 371678a to ed389b5 Compare October 29, 2022 17:06
@tomasurb26
Copy link

Hello, is this solution already usable or are there any things that needs to be completed? Would like to try this functionality. Also I can help with Slovak translation if needed. Thanks.

@frnd
Copy link
Author

frnd commented Nov 1, 2022

Hello, is this solution already usable or are there any things that needs to be completed? Would like to try this functionality. Also I can help with Slovak translation if needed. Thanks.

Hi Tomas. The functionality is complete and usable, however I would appreciate it if someone could test it for bugs or missing features.

@tomasurb26
Copy link

Hello, is this solution already usable or are there any things that needs to be completed? Would like to try this functionality. Also I can help with Slovak translation if needed. Thanks.

Hi Tomas. The functionality is complete and usable, however I would appreciate it if someone could test it for bugs or missing features.

Thank you for your reply. I am testing currently. Do you think I will be able to integrate/merge it with release v1.4.3 as I am using this one in production?

Maybe some missing features:

  • different colors for paid and unpaid appointments in calendar view(now it is needed to click on every single one to check)
  • integrate payment link to be shown on the appointment confirmation page - so the user can click and be redirected directly.

@alextselegidis
Copy link
Owner

Hello!

Thanks for completing this PR!

Since we are very close to releasing 1.5, this will need to go to the next version, but I will happily test it thoroughly and merge accordingly.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@frnd
Copy link
Author

frnd commented Nov 3, 2022

* different colors for paid and unpaid appointments in calendar view(now it is needed to click on every single one to check)

* integrate payment link to be shown on the appointment confirmation page - so the user can click and be redirected directly.

Thanks for your suggestions, I'm going to implement them.

@frnd frnd force-pushed the feature/add_payment_by_link branch from ed389b5 to b07226a Compare November 6, 2022 14:27
@tomasurb26
Copy link

* different colors for paid and unpaid appointments in calendar view(now it is needed to click on every single one to check)

* integrate payment link to be shown on the appointment confirmation page - so the user can click and be redirected directly.

Thanks for your suggestions, I'm going to implement them.

Hello,
thank you.
I found one bug, on payment confirmation screen Add to Google calendar button has the wrong link, it goes to https://domain.ltd/index.php/payment/confirm/cs_test_a1XAr5aQwv0OOQyWXJx...........................

Regarding the color change after payment, I solved it temporarily with adding $appointment['color'] = '#00a36c'; in set_paid() function in Payment.php.

Thanks for now.

@frnd frnd force-pushed the feature/add_payment_by_link branch from b07226a to 3a9c6ee Compare November 12, 2022 14:55
@frnd
Copy link
Author

frnd commented Nov 12, 2022

Hello Tomas.

Thanks for the testing!!

I have added new code for your suggestions:

  • A new button in booking confirmation screen to proceed with payment.
  • A red border for unpaid appointments in calendar view. I think changing the border is better solution than overriding background colour, so the user can still use appointment colours.

Can you retest the bug you found with latest version? I can not reproduce it. Thanks.

@frnd frnd force-pushed the feature/add_payment_by_link branch from 3a9c6ee to d29242d Compare November 13, 2022 19:07
@frnd frnd force-pushed the feature/add_payment_by_link branch from d29242d to 19b92cf Compare November 26, 2022 17:21
@fliot
Copy link

fliot commented Apr 30, 2023

This functionality is super interesting !
Congrats.

@frnd frnd force-pushed the feature/add_payment_by_link branch 2 times, most recently from 8eef29a to 4aa8970 Compare October 19, 2023 12:43
@frnd frnd force-pushed the feature/add_payment_by_link branch from 4aa8970 to 24ee1d3 Compare May 2, 2024 22:40
@alextselegidis alextselegidis changed the title Add Stripe payment by link. Add Stripe payment by payment link Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants