Introduce dump, rename Str to Txt, fixes namespace collision #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coral's pseudodatastructures use global counters to keep track of stored values. These are namespaced into four variables, which were _S _L _S _A. Reusing _S for sets and strings is no longer supported, and now strings have their own namespace _T for Txt. I also considered renaming `val` to `var`, then `Str` to `Val`, but that collides with some unstandard osh builtins, so we have to find another way. Txt sounds like a good compromise. This commit also introduces the dump function, which recursively builds a serialization of any pseudodatastructure reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coral's pseudodatastructures use global counters to keep track of stored values. These are namespaced into four variables, which were _S _L _S _A. Reusing _S for sets and strings is no longer supported, and now strings have their own namespace _T for Txt.
I also considered renaming
valtovar, thenStrtoVal, but that collides with some unstandard osh builtins, so we have to find another way. Txt sounds like a good compromise.This commit also introduces the dump function, which recursively builds a serialization of any pseudodatastructure reference.