fix(scripts): update release issue process #537
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
.github/workflows/check.yml
Outdated
| @@ -325,9 +325,11 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.TOKEN_GENERATE_BOT }} | |||
| PR_NUMBER: ${{ github.event.number }} | |||
| IS_RELEASE_COMMIT: ${{ github.event.head_commit.message }} | |||
There was a problem hiding this comment.
I have a doubt on this one, hopefully it prints the latest commit message once on main
| @@ -64,7 +64,7 @@ async function preCommit() { | |||
| } | |||
|
|
|||
| console.log( | |||
| chalk.bgYellow('[INFO]'), | |||
| chalk.black.bgYellow('[INFO]'), | |||
| async function createReleaseIssue(): Promise<void> { | ||
| ensureGitHubToken(); | ||
|
|
||
| if (!process.env.LOCAL_TEST_DEV) { |
There was a problem hiding this comment.
We want to be able to test things locally from other branches, so I've added this condition
| coAuthors: [author, ...coAuthors], | ||
| cwd: tempGitDir, | ||
| }); | ||
| await run(`git push`, { cwd: tempGitDir }); | ||
| await execa('git', ['tag', tag], { |
There was a problem hiding this comment.
why use execa here ? it's the same as git tag ${tag} no ?
There was a problem hiding this comment.
idk, it was like this already so I've assumed there was a reason behind it, any idea @eunjae-lee ?
| @@ -6,7 +6,6 @@ | |||
| "createMatrix": "ts-node ci/githubActions/createMatrix.ts", | |||
| "createReleaseIssue": "ts-node release/create-release-issue.ts", | |||
There was a problem hiding this comment.
is createReleaseIssue still used ?
There was a problem hiding this comment.
Yep to create a PR, I wanted to rename it in this PR but I was afraid the diff would be too big, so I'll do it before merging/once merged
|
|
||
| if ( | ||
| message | ||
| .toLocaleLowerCase() |
There was a problem hiding this comment.
why the lowercase ? it's not used for any other test, it should always be the same format
There was a problem hiding this comment.
At the beginning of the codegen, there was capitalized letters in the commit message, to make it future proof (once we re-generate the changelog from scratch for the official version for example), I've added it
| @@ -4,6 +4,7 @@ import dotenv from 'dotenv'; | |||
| import semver from 'semver'; | |||
There was a problem hiding this comment.
shoud this be called createReleasePR ?
There was a problem hiding this comment.
Yep! context here: #537 (comment)
| @@ -23,6 +23,7 @@ export const MAIN_BRANCH = releaseConfig.mainBranch; | |||
| export const OWNER = releaseConfig.owner; | |||
| export const REPO = releaseConfig.repo; | |||
| export const REPO_URL = `https://github.com/${OWNER}/${REPO}`; | |||
| export const TODAY = new Date().toISOString().split('T')[0]; | |||
There was a problem hiding this comment.
let's not release around midnight ahah
There was a problem hiding this comment.
I said the same to Eunjae this morning
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-499
Changes included:
This PR aims at harmonizing our release process with our CI, to prevent any duplication of the generation logic.
yarn releasereleaseactionThe release now runs at the very end of the CI, on
mainbranch, and leverages our existingcodegenandspreadscriptscodegenspreadNext
Testing :D
🧪 Test
yarn release: chore: prepare release 2022-05-24 #542LOCAL_TEST_DEVif you'd like to try it locally too