Skip to content

Commit

Permalink
Fix: splitChunk config in speedup mode (#7013)
Browse files Browse the repository at this point in the history
* fix: splitChunk config in speedup mode

* chore: remove comment

* fix: update comment
  • Loading branch information
ClarkXia authored Nov 8, 2024
1 parent 9e7615b commit 4130611
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/breezy-ants-clap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ice/rspack-config': patch
---

fix: update splitChunk config
5 changes: 3 additions & 2 deletions packages/rspack-config/src/splitChunks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ export const getVendorStrategy = (options: Configuration['splitChunks']) => {

const getSplitChunks = (_: string, strategy: string | boolean) => {
if (strategy === false) {
// Empty splitChunks configuration if strategy is false.
return {};
// Set minChunks to a large number to disable the splitChunks feature.
// the value of Infinity is not work properly for this version of rspack.
return { minChunks: 100000, cacheGroups: { default: false } };
} else if (typeof strategy === 'string' && ['page-vendors', 'vendors'].includes(strategy)) {
const splitChunksOptions = strategy === 'page-vendors' ? { chunks: 'all' } : {};
return getVendorStrategy(splitChunksOptions);
Expand Down

0 comments on commit 4130611

Please sign in to comment.