Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@ice/app): exports internal router api #6710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linbudu599
Copy link
Collaborator

@linbudu599 linbudu599 commented Dec 25, 2023

Exports router api for programmatic usage like Incremental router registry.

TODO: Is there additional input for router building?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23811c8) 79.95% compared to head (7046679) 79.95%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/next    #6710   +/-   ##
=============================================
  Coverage         79.95%   79.95%           
=============================================
  Files               218      218           
  Lines             19001    19001           
  Branches           2452     2452           
=============================================
  Hits              15192    15192           
  Misses             3778     3778           
  Partials             31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from release/next to master January 4, 2024 07:10
wssgcg1213
wssgcg1213 previously approved these changes Feb 5, 2024
@wssgcg1213 wssgcg1213 changed the base branch from master to release/next February 5, 2024 01:59
@wssgcg1213 wssgcg1213 dismissed their stale review February 5, 2024 01:59

The base branch was changed.

wssgcg1213
wssgcg1213 previously approved these changes Feb 5, 2024
Base automatically changed from release/next to master February 26, 2024 06:27
@ClarkXia ClarkXia dismissed wssgcg1213’s stale review February 26, 2024 06:27

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants