Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: splitChunk config in speedup mode #7013

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix: splitChunk config in speedup mode #7013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da64db6
fix: splitChunk config in speedup mode
ClarkXia Oct 31, 2024
ca654d8
chore: remove comment
ClarkXia Oct 31, 2024
00063e8
fix: update comment
ClarkXia Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-ants-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ice/rspack-config': patch
---

fix: update splitChunk config
5 changes: 3 additions & 2 deletions packages/rspack-config/src/splitChunks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ export const getVendorStrategy = (options: Configuration['splitChunks']) => {

const getSplitChunks = (_: string, strategy: string | boolean) => {
if (strategy === false) {
// Empty splitChunks configuration if strategy is false.
return {};
// Set minChunks to a large number to disable the splitChunks feature.
// the value of Infinity is not work properly for this version of rspack.
return { minChunks: 100000, cacheGroups: { default: false } };
} else if (typeof strategy === 'string' && ['page-vendors', 'vendors'].includes(strategy)) {
const splitChunksOptions = strategy === 'page-vendors' ? { chunks: 'all' } : {};
return getVendorStrategy(splitChunksOptions);
Expand Down
Loading