Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Component: Landing Page(Page) #235 #242

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Conversation

n-y-kim
Copy link
Contributor

@n-y-kim n-y-kim commented Aug 20, 2024

#235

Page 생성이라 딱히 추가할 코드가 없는 상황입니다.
해당 기능도 테스트 코드가 필요한가요?

@justinyoo
Copy link
Contributor

페이지가 만들어졌다면, 접속이 가능한지 테스트가 필요하겠지요? AppHost 프로젝트에서 테스트 코드를 추가해 보세요.

@n-y-kim
Copy link
Contributor Author

n-y-kim commented Aug 25, 2024

@justinyoo 테스트 코드 추가 확인 부탁드립니다

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

글로벌 using 디렉티브만 처리하면 될 듯?

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinyoo justinyoo merged commit 485cbe9 into aliencube:main Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin] Component: Landing Page(Page)
2 participants