[Backend API] Add Table Name property to appsettings.json #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: aliencube#319
fix property name "Name" to "TableName" because "Name" is duplicated in TableSettings.cs Related to: aliencube#319
Related to: aliencube#319
Related to: aliencube#319
justinyoo
requested changes
Sep 14, 2024
src/AzureOpenAIProxy.ApiApp/Extensions/StorageSettingsExtensions.cs
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
Outdated
Show resolved
Hide resolved
Related to: aliencube#319
Related to: aliencube#319
|
기존에 존재하는 테스트들 중, 수정사항에 영향을 받는 테스트들은 업데이트 했고 |
justinyoo
requested changes
Sep 16, 2024
src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
Outdated
Show resolved
Hide resolved
test/AzureOpenAIProxy.ApiApp.Tests/Repositories/AdminEventRepositoryTests.cs
Show resolved
Hide resolved
justinyoo
requested changes
Sep 16, 2024
src/AzureOpenAIProxy.ApiApp/Extensions/StorageAccountSettingsExtensions.cs
Outdated
Show resolved
Hide resolved
StorageAccountExtensions don't need to exist in their own file. Related to: aliencube#319
Related to: aliencube#319
sikutisa
deleted the
feature/319-Add-Table-Name-property-to-appsettings.json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appsettings.json#319Description
StorageAccountSettings를 싱글톤으로 등록AddAdminEventRepository에TableServiceClient와StorageAccountSettings의존성 주입