Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Linter alingse-makezero.yaml For Top 1w github golang repo #1

Open
alingse opened this issue May 26, 2024 · 271 comments
Open

Run Linter alingse-makezero.yaml For Top 1w github golang repo #1

alingse opened this issue May 26, 2024 · 271 comments

Comments

@alingse
Copy link
Owner

alingse commented May 26, 2024 •
edited
Loading

The job config yaml https://github.com/alingse/go-linter-runner/blob/main/jobs/alingse-makezero.yaml

name: alingse-makezero
linter: makezero
workdir: .
install: go install github.com/alingse/makezero@f6a823578e89de5cdfdfef50d4a5d9a09ade16dd
includes:
  - non-zero initialized length
excludes:
  - called by funcs
  - assigned by index

Real Bugs

  1. fix: fix miss makezero bug milvus-io/milvus#33386
  2. fix: fix miss makezero bug google/pprof#867
  3. fix: fix miss makezero bug kubernetes/kubernetes#125132
  4. chore: fix miss makezero bug gogs/gogs#7752
  5. fix: fix miss makezero bug brianvoe/gofakeit#358
  6. [Kaniko] Fix non-zero slice initialization nuclio/nuclio#3251
  7. fix: fix miss makezero bug goodrain/rainbond#1921
  8. fix: fix miss makezero bug apache/dubbo-go#2682
  9. fix: fix miss makezero bug kubernetes/test-infra#32662
  10. fix: fix miss makezero bug m3db/m3#4268
  11. fix: fix miss makezero bug mosn/mosn#2393
  12. fix: fix miss makezero bug cube2222/octosql#334
  13. fix(cubefs): fix miss makezero bug cubefs/cubefs#3393
  14. fix: fix miss makezero bug openkruise/kruise#1628
  15. fix: fix miss makezero bug ovh/cds#6971
  16. fix: fix miss makezero bug tailwarden/komiser#1428
  17. fix: fix miss makezero bug hashicorp/terraform-provider-google#18251
  18. fix: fix miss makezero bug cdk-team/CDK#101
  19. fix: fix miss makezero bug netlify/gotrue#363
  20. ci(lint): don't accidentally append to non-zero length slices kumahq/kuma#10317
  21. Fix miss makezero bug divan/txqr#15
  22. Bug Report: miss makezero in slice moncho/dry#229
  23. [bug]: miss makezero in slice init lindb/lindb#1029
  24. bug report: miss makezero in slice init montanaflynn/stats#84
  25. [bug] miss makezero in slice init koderover/zadig#3531
  26. miss makezero in slice init argoproj/argo-rollouts#3600
  27. miss makezero in slice init getgauge/gauge#2545
  28. miss makezero in slice init StackExchange/dnscontrol#2981
  29. miss makezero in slice init fleetdm/fleet#19290
  30. miss makezero in slice init googleforgames/open-match#1764
  31. miss makezero in slice init wal-g/wal-g#1722
  32. miss makezero in slice init rancher/rke#3592
  33. miss makezero in slice init aquasecurity/tracee#4081
  34. miss makezero in slice init erigontech/erigon#10504
  35. miss makezero in slice init nakabonne/ali#139
  36. [BUG] miss makezero in slice init DataDog/datadog-agent#25971
  37. [Bug report]: miss makezero in slice init frain-dev/convoy#2019
  38. [Bug Report] miss makezero in slice init bilibili/overlord#177
  39. miss makezero in slice init SpectoLabs/hoverfly#1131
  40. [BUG] miss makezero in slice init unidoc/unipdf#555

False Positive

Assigned

  1. https://github.com/gorgonia/gorgonia
  2. https://github.com/cockroachdb/pebble/blob/master/tool/db_io_bench.go#L100
  3. https://github.com/EndlessCheng/codeforces-go/blob/master/main/1300-1399/1381B.go#L27
  4. https://github.com/arp242/goatcounter/blob/master/hit_list.go#L319
  5. https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/state/state-native/setters_misc.go#L193
  6. https://github.com/prometheus/prometheus/blob/main/scrape/scrape.go#L1693:16
  7. https://github.com/q191201771/lal/blob/master/pkg/avc/avc.go#L244:9

Assigned by Index With Attr

  1. https://github.com/tenable/terrascan/blob/master/pkg/mapper/iac-providers/cft/config/ec2-instance.go#L154
  2. https://github.com/canonical/lxd/blob/main/lxc/image.go#L302

Others

  1. https://github.com/travisjeffery/jocko/blob/master/commitlog/message_set.go#L16 (the message header is keep)
  2. https://github.com/osrg/gobgp/blob/master/pkg/packet/bgp/bgp.go#L2685:8 i don't know
  3. https://github.com/gocql/gocql/blob/master/frame.go#L968-L971
  4. https://github.com/bnb-chain/bsc/blob/master/core/vm/lightclient/v2/lightclient.go#L244:12
This was referenced May 26, 2024
Closed
Merged
Open
Merged
Closed
Merged
Merged
Merged
Merged
Open
Open
Open
Open
Merged
Merged
Merged
Closed
Open
Open
Merged
Open
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Open
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/elastic/beats

Got total 7 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732136100

Expand
  1. libbeat/template/processor.go#L184:26 WARNING: could not determine with "defaultFields" at is a slice (missing object type)
  2. libbeat/template/template.go#L314:11 append to slice fields with non-zero initialized length, and called by funcs: copy at
  3. libbeat/processors/ratelimit/limit.go#L57:18 append to slice allowedStrs with non-zero initialized length at
  4. libbeat/processors/ratelimit/rate_limit.go#L142:12 append to slice values with non-zero initialized length at
  5. dev-tools/mage/platforms.go#L370:9 append to slice out with non-zero initialized length, and called by funcs: copy at
  6. filebeat/beater/filebeat.go#L566:12 append to slice inputs with non-zero initialized length, and called by funcs: copy at
  7. metricbeat/helper/labelhash/hash.go#L56:9 append to slice ls with non-zero initialized length at

Report issue: https://github.com/elastic/beats/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/lib/pq

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732141473

Expand
  1. encode.go#L557:15 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  2. encode.go#L570:14 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  3. encode.go#L577:15 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  4. encode.go#L580:14 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at

Report issue: https://github.com/lib/pq/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/lib/pq

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732141473

Expand
  1. encode.go#L557:15 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  2. encode.go#L570:14 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  3. encode.go#L577:15 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at
  4. encode.go#L580:14 append to slice result with non-zero initialized length, and called by funcs: hex.Decode at

Report issue: https://github.com/lib/pq/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/open-policy-agent/opa

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732140458

Expand
  1. internal/jwx/jws/sign/ecdsa.go#L51:10 append to slice rBytesPadded with non-zero initialized length at
  2. plugins/rest/auth.go#L230:18 append to slice rBytesPadded with non-zero initialized length at
  3. internal/cidr/merge/merge.go#L297:19 append to slice zeroBytes with non-zero initialized length at
  4. internal/cidr/merge/merge.go#L307:19 append to slice zeroBytes with non-zero initialized length at

Report issue: https://github.com/open-policy-agent/opa/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/google/go-cloud

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732140776

Expand
  1. internal/escape/escape.go#L148:16 append to slice unescaped with non-zero initialized length, and called by funcs: copy at
  2. internal/escape/escape.go#L151:16 append to slice unescaped with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/google/go-cloud/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/gravitational/teleport

Got total 3 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732134121

Expand
  1. lib/sshutils/x11/auth.go#L249:9 append to slice initBuf with non-zero initialized length, and called by funcs: io.ReadFull,readXauthPacketInitBuf at
  2. lib/utils/socks/socks.go#L110:17 append to slice authMethods with non-zero initialized length at
  3. lib/srv/desktop/discovery.go#L256:12 append to slice attrs with non-zero initialized length at

Report issue: https://github.com/gravitational/teleport/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/google/go-cloud

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732140776

Expand
  1. internal/escape/escape.go#L148:16 append to slice unescaped with non-zero initialized length, and called by funcs: copy at
  2. internal/escape/escape.go#L151:16 append to slice unescaped with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/google/go-cloud/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/ccfos/nightingale

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732140976

Expand
  1. alert/dispatch/notify_target.go#L90:10 append to slice uids with non-zero initialized length at

Report issue: https://github.com/ccfos/nightingale/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/ccfos/nightingale

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732140976

Expand
  1. alert/dispatch/notify_target.go#L90:10 append to slice uids with non-zero initialized length at

Report issue: https://github.com/ccfos/nightingale/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/gcla/termshark

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142227

Expand
  1. ui/searchalg.go#L115:30 WARNING: could not determine with "CacheRequests" at is a slice (missing object type)

Report issue: https://github.com/gcla/termshark/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/projectdiscovery/katana

Got total 7 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142022

Expand
  1. pkg/engine/parser/parser_generic.go#L17:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  2. pkg/engine/parser/parser_generic.go#L20:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  3. pkg/engine/parser/parser_generic.go#L21:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  4. pkg/engine/parser/parser_generic.go#L24:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  5. pkg/engine/parser/parser_generic.go#L25:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  6. pkg/engine/parser/parser_generic.go#L26:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)
  7. pkg/engine/parser/parser_generic.go#L29:28 WARNING: could not determine with "responseParsers" at is a slice (missing object type)

Report issue: https://github.com/projectdiscovery/katana/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/lightningnetwork/lnd

Got total 5 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142254

Expand
  1. channeldb/migration_01_to_11/migrations.go#L167:22 append to slice invoiceBytesCopy with non-zero initialized length, and called by funcs: copy at
  2. channeldb/migration_01_to_11/migrations.go#L299:17 append to slice paymentCopy with non-zero initialized length at
  3. channeldb/migration_01_to_11/migrations.go#L300:17 append to slice paymentCopy with non-zero initialized length at
  4. lnwallet/commitment.go#L811:11 append to slice cltvs with non-zero initialized length at
  5. lnwallet/commitment.go#L829:11 append to slice cltvs with non-zero initialized length at

Report issue: https://github.com/lightningnetwork/lnd/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/codenotary/immudb

Got total 3 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142757

Expand
  1. embedded/sql/row_reader.go#L294:13 append to slice hiKey with non-zero initialized length, and called by funcs: copy at
  2. embedded/sql/row_reader.go#L306:13 append to slice loKey with non-zero initialized length, and called by funcs: copy at
  3. embedded/sql/row_reader.go#L312:10 append to slice hiKey with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/codenotary/immudb/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/codenotary/immudb

Got total 3 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142757

Expand
  1. embedded/sql/row_reader.go#L294:13 append to slice hiKey with non-zero initialized length, and called by funcs: copy at
  2. embedded/sql/row_reader.go#L306:13 append to slice loKey with non-zero initialized length, and called by funcs: copy at
  3. embedded/sql/row_reader.go#L312:10 append to slice hiKey with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/codenotary/immudb/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/lightningnetwork/lnd

Got total 5 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142254

Expand
  1. channeldb/migration_01_to_11/migrations.go#L167:22 append to slice invoiceBytesCopy with non-zero initialized length, and called by funcs: copy at
  2. channeldb/migration_01_to_11/migrations.go#L299:17 append to slice paymentCopy with non-zero initialized length at
  3. channeldb/migration_01_to_11/migrations.go#L300:17 append to slice paymentCopy with non-zero initialized length at
  4. lnwallet/commitment.go#L811:11 append to slice cltvs with non-zero initialized length at
  5. lnwallet/commitment.go#L829:11 append to slice cltvs with non-zero initialized length at

Report issue: https://github.com/lightningnetwork/lnd/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/cloudflare/cloudflared

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142895

Expand
  1. config/configuration.go#L83:10 append to slice dirs with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/cloudflare/cloudflared/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/cloudflare/cloudflared

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142895

Expand
  1. config/configuration.go#L83:10 append to slice dirs with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/cloudflare/cloudflared/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/openshift/origin

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732139224

Expand
  1. pkg/monitortests/testframework/alertanalyzer/alerts.go#L222:14 append to slice newRet with non-zero initialized length, and called by funcs: copy at
  2. pkg/monitortests/testframework/alertanalyzer/alerts.go#L229:14 append to slice newRet with non-zero initialized length, and called by funcs: copy at
  3. test/extended/prometheus/prometheus.go#L677:25 append to slice allowedAlertNames with non-zero initialized length, and called by funcs: copy at
  4. test/extended/prometheus/prometheus.go#L684:25 append to slice allowedAlertNames with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/openshift/origin/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/fission/fission

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142679

Expand
  1. pkg/fetcher/config/config.go#L306:29 append to slice existingContainerNames with non-zero initialized length at
  2. pkg/fission-cli/cliwrapper/driver/cobra/cobra.go#L271:10 append to slice vals with non-zero initialized length at

Report issue: https://github.com/fission/fission/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/fission/fission

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142679

Expand
  1. pkg/fetcher/config/config.go#L306:29 append to slice existingContainerNames with non-zero initialized length at
  2. pkg/fission-cli/cliwrapper/driver/cobra/cobra.go#L271:10 append to slice vals with non-zero initialized length at

Report issue: https://github.com/fission/fission/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/moby/buildkit

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732143029

Expand
  1. frontend/dockerfile/instructions/commands_runmount.go#L50:28 WARNING: could not determine with "parseRunPreHooks" at is a slice (missing object type)
  2. frontend/dockerfile/instructions/commands_runmount.go#L51:29 WARNING: could not determine with "parseRunPostHooks" at is a slice (missing object type)
  3. frontend/dockerfile/instructions/commands_runnetwork.go#L29:28 WARNING: could not determine with "parseRunPreHooks" at is a slice (missing object type)
  4. frontend/dockerfile/instructions/commands_runnetwork.go#L30:29 WARNING: could not determine with "parseRunPostHooks" at is a slice (missing object type)

Report issue: https://github.com/moby/buildkit/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/aws/aws-sdk-go

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732141164

Expand
  1. private/protocol/xml/xmlutil/xml_to_struct.go#L135:18 append to slice sortedAttrs with non-zero initialized length at
  2. internal/smithytesting/xml/xmlToStruct.go#L142:18 append to slice sortedAttrs with non-zero initialized length at

Report issue: https://github.com/aws/aws-sdk-go/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/drakkan/sftpgo

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142953

Expand
  1. internal/util/util.go#L585:7 append to slice b with non-zero initialized length, and called by funcs: io.ReadFull,len at
  2. internal/sftpd/ssh_cmd.go#L422:10 append to slice args with non-zero initialized length, and called by funcs: copy,len at

Report issue: https://github.com/drakkan/sftpgo/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/drakkan/sftpgo

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732142953

Expand
  1. internal/util/util.go#L585:7 append to slice b with non-zero initialized length, and called by funcs: io.ReadFull,len at
  2. internal/sftpd/ssh_cmd.go#L422:10 append to slice args with non-zero initialized length, and called by funcs: copy,len at

Report issue: https://github.com/drakkan/sftpgo/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/kubernetes-sigs/external-dns

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732143101

Expand
  1. provider/ovh/ovh.go#L300:16 append to slice ovhRecords with non-zero initialized length at

Report issue: https://github.com/kubernetes-sigs/external-dns/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/kubernetes-sigs/external-dns

Got total 1 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732143101

Expand
  1. provider/ovh/ovh.go#L300:16 append to slice ovhRecords with non-zero initialized length at

Report issue: https://github.com/kubernetes-sigs/external-dns/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/openshift/origin

Got total 4 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732139224

Expand
  1. pkg/monitortests/testframework/alertanalyzer/alerts.go#L222:14 append to slice newRet with non-zero initialized length, and called by funcs: copy at
  2. pkg/monitortests/testframework/alertanalyzer/alerts.go#L229:14 append to slice newRet with non-zero initialized length, and called by funcs: copy at
  3. test/extended/prometheus/prometheus.go#L677:25 append to slice allowedAlertNames with non-zero initialized length, and called by funcs: copy at
  4. test/extended/prometheus/prometheus.go#L684:25 append to slice allowedAlertNames with non-zero initialized length, and called by funcs: copy at

Report issue: https://github.com/openshift/origin/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/aws/aws-sdk-go

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732141164

Expand
  1. private/protocol/xml/xmlutil/xml_to_struct.go#L135:18 append to slice sortedAttrs with non-zero initialized length at
  2. internal/smithytesting/xml/xmlToStruct.go#L142:18 append to slice sortedAttrs with non-zero initialized length at

Report issue: https://github.com/aws/aws-sdk-go/issues

@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/kedacore/keda

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732143542

Expand
  1. controllers/keda/scaledjob_controller.go#L357:18 append to slice triggerTypes with non-zero initialized length at
  2. controllers/keda/scaledobject_controller.go#L585:18 append to slice triggerTypes with non-zero initialized length at

Report issue: https://github.com/kedacore/keda/issues

1 similar comment
@github-actions GitHub Actions
Copy link

Run makezero on Repo: https://github.com/kedacore/keda

Got total 2 line output in action: https://github.com/alingse/go-linter-runner/actions/runs/9732143542

Expand
  1. controllers/keda/scaledjob_controller.go#L357:18 append to slice triggerTypes with non-zero initialized length at
  2. controllers/keda/scaledobject_controller.go#L585:18 append to slice triggerTypes with non-zero initialized length at

Report issue: https://github.com/kedacore/keda/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alingse