Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix miss makezero bug #33386

Closed
wants to merge 1 commit into from

Conversation

alingse
Copy link

@alingse alingse commented May 26, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9241746915/job/25423640197

====================================================================================================
append to slice `partitionIDs` with non-zero initialized length at https://github.com/milvus-io/milvus/blob/master/internal/rootcoord/broker.go#L242:18
append to slice `pairs` with non-zero initialized length at https://github.com/milvus-io/milvus/blob/master/cmd/tools/migration/meta/2[10](https://github.com/alingse/go-linter-runner/actions/runs/9241746915/job/25423640197#step:4:11)_to_220.go#L64:11
append to slice `servers` with non-zero initialized length at https://github.com/milvus-io/milvus/blob/master/tests/integration/minicluster_v2.go#L257:13
====================================================================================================
Report issue: https://github.com/milvus-io/milvus/issues

@sre-ci-robot
Copy link
Contributor

Welcome @alingse! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alingse
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label May 26, 2024
Copy link
Contributor

mergify bot commented May 26, 2024

@alingse Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented May 26, 2024

@alingse

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@alingse alingse changed the title Fix miss makezero bug fix: fix miss makezero bug May 26, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels May 26, 2024
Copy link
Contributor

mergify bot commented May 26, 2024

@alingse Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 26, 2024
Copy link
Contributor

mergify bot commented May 26, 2024

@alingse E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (36cbce4) to head (88f3ff0).
Report is 529 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33386      +/-   ##
==========================================
+ Coverage   82.12%   82.17%   +0.04%     
==========================================
  Files        1012     1012              
  Lines      128862   128862              
==========================================
+ Hits       105828   105892      +64     
+ Misses      19061    18997      -64     
  Partials     3973     3973              
Files Coverage Δ
internal/rootcoord/broker.go 92.10% <100.00%> (ø)
tests/integration/minicluster_v2.go 72.72% <100.00%> (ø)

... and 38 files with indirect coverage changes

Copy link

stale bot commented Jun 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 26, 2024
@stale stale bot closed this Jul 3, 2024
@alingse
Copy link
Author

alingse commented Jul 3, 2024

/reopen

@sre-ci-robot sre-ci-robot reopened this Jul 3, 2024
@sre-ci-robot
Copy link
Contributor

@alingse: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed the stale indicates no udpates for 30 days label Jul 3, 2024
@alingse
Copy link
Author

alingse commented Jul 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 3, 2024

@alingse E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alingse
Copy link
Author

alingse commented Jul 3, 2024

/assign @xiaofan-luan

Copy link
Contributor

mergify bot commented Jul 3, 2024

@alingse E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

stale bot commented Aug 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Aug 3, 2024
@stale stale bot closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug sig/testing size/XS Denotes a PR that changes 0-9 lines. stale indicates no udpates for 30 days test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants