Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE SDK Auto Released By yinxi #263

Merged
merged 2 commits into from
May 30, 2019
Merged

CORE SDK Auto Released By yinxi #263

merged 2 commits into from
May 30, 2019

Conversation

doublnt
Copy link
Contributor

@doublnt doublnt commented May 30, 2019

发布日志:
1, Add editor config file

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

sdk-team and others added 2 commits May 30, 2019 09:45
@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #263   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          64     64           
  Lines        3323   3323           
  Branches      334    334           
=====================================
  Hits         3157   3157           
  Misses        111    111           
  Partials       55     55
Flag Coverage Δ
#unittest 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f201b...0cd5752. Read the comment docs.

@doublnt doublnt requested a review from Qingtang-SDK May 30, 2019 02:00
update product
### 2019-05-28 Version 2.3.2
更新 2.3.2
### 2019-05-28 Version 2.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是新的发布系统 发布产品时,更新到 core 的 changlog 中了,已和温作超说了这个 bug

@@ -0,0 +1,200 @@
# EditorConfig is awesome: https://EditorConfig.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

编辑器配置应当是个人的配置吧。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里面配置的是 代码风格, 比如缩进,空格等规范,目的是为了让其他贡献者提PR时能做到和原来的代码风格和规范保持一致,目前的规范来自 微软 C# 编译器 Roslyn 的规范 https://github.com/dotnet/roslyn/blob/master/.editorconfig

@JacksonTian JacksonTian merged commit 61bd4e9 into master May 30, 2019
@doublnt doublnt deleted the add_editorconfig_file branch May 30, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants