custom deserde impl #2017
Merged
custom deserde impl #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siosw
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
mattsse
requested changes
Feb 6, 2025
| @@ -373,6 +380,161 @@ impl ExecutionPayloadV1 { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "serde")] | |||
| impl<'de> Deserialize<'de> for ExecutionPayloadV1 { | |||
There was a problem hiding this comment.
I don't want to touch serde on the versioned types directly but we should implement it like this for the ExecutionPayload enum
deserializing all fields and then selecting the version based on the fields
There was a problem hiding this comment.
ah fair, and then i guess remove the derived deserialize from the versioned types?
There was a problem hiding this comment.
no we need proper serde on ExecutionPayloadV1 ExecutionPayloadV2 ExecutionPayloadV3 (no changes required)
we only need manual deserde on ExecutionPayload which then is implemented like this draft
siosw
force-pushed
the
siosw/faulty-roundtrip-fix
branch
2 times, most recently
from
93096cf to
8e63f18
Compare
mattsse
requested changes
Feb 7, 2025
mattsse
requested changes
Feb 7, 2025
| fn serde_payload_input_enum_v3() { | ||
| let response_v3 = r#"{"parentHash":"0xe927a1448525fb5d32cb50ee1408461a945ba6c39bd5cf5621407d500ecc8de9","feeRecipient":"0x0000000000000000000000000000000000000000","stateRoot":"0x10f8a0830000e8edef6d00cc727ff833f064b1950afd591ae41357f97e543119","receiptsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","prevRandao":"0xe0d8b4521a7da1582a713244ffb6a86aa1726932087386e2dc7973f43fc6cb24","blockNumber":"0x1","gasLimit":"0x2ffbd2","gasUsed":"0x0","timestamp":"0x1235","extraData":"0xd883010d00846765746888676f312e32312e30856c696e7578","baseFeePerGas":"0x342770c0","blockHash":"0x44d0fa5f2f73a938ebb96a2a21679eb8dea3e7b7dd8fd9f35aa756dda8bf0a8a","transactions":[],"withdrawals":[],"blobGasUsed":"0x0","excessBlobGas":"0x0"}"#; | ||
|
|
||
| let payload: ExecutionPayload = serde_json::from_str(response_v3).unwrap(); |
There was a problem hiding this comment.
can we add roundtrips to all of the tests to ensure that payload serializes into the same serde_json::Value as response_v3
| transactions, | ||
| }; | ||
|
|
||
| if let Some(withdrawals) = withdrawals { |
There was a problem hiding this comment.
you can also use
let Some(Some(withdrawals) = withdrawals else {
return ...
}
syntax here
siosw
force-pushed
the
siosw/faulty-roundtrip-fix
branch
from
7dfb114 to
e686a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #2015
unsure about the following: