feat: builder fns for PrivateTransactionRequest and inner props (#1954) #2023
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-rs#1954) Signed-off-by: Aliaksei Misiukevich <[email protected]>
nadtech-hub
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
|
afaik, you lot don't cover such functionality with tests, do you? |
Signed-off-by: Aliaksei Misiukevich <[email protected]>
Signed-off-by: Aliaksei Misiukevich <[email protected]>
nadtech-hub
force-pushed
the
nadtech/priv-tx-req-helpers
branch
from
c1ab985 to
2ac88db
Compare
Signed-off-by: Aliaksei Misiukevich <[email protected]>
I was struggling to understand usage of this request |
mattsse
requested changes
Feb 7, 2025
Comment on lines
+316
to
+323
| Self { | ||
| tx: envelope.encoded_2718().into(), | ||
| max_block_number: None, | ||
| preferences: PrivateTransactionPreferences { | ||
| fast: None, | ||
| validity: None, | ||
| privacy: None, | ||
| }, |
There was a problem hiding this comment.
can we use a new function for this as well, from functions alone are more obfuscated
There was a problem hiding this comment.
is empty Bytes allowed?
There was a problem hiding this comment.
no but all those fields are pub,
the only thing missing here is this from fn as
impl PrivateTransactionRequest {
pub fn new<T>() -> Self {
Self {
tx: envelope.encoded_2718().into(),
max_block_number: None,
preferences: PrivateTransactionPreferences {
fast: None,
validity: None,
privacy: None,
},
}
and then the from function would just call PrivateTransactionRequest::new(tx)
There was a problem hiding this comment.
makes some sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Builder style functions for PrivateTransactionRequest
Solution
Added PrivateTransactionRequest's and inner properties implementation blocks containing builder fns
PR Checklist