feat: use OnceCell for Signed::hash
#2025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
klkvr
force-pushed
the
klkvr/lazy-hash
branch
from
329cc37 to
3638021
Compare
klkvr
force-pushed
the
klkvr/lazy-hash
branch
from
3638021 to
2b43842
Compare
klkvr
force-pushed
the
klkvr/lazy-hash
branch
from
2b43842 to
f58fb6a
Compare
mattsse
reviewed
Feb 7, 2025
|
Why can't we use std here? |
|
we can but we'd still need once_cell in no-std |
|
@klkvr we can simply upstream this to alloy: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #1987
Lazily computes hash for the transaction in
Signed. Methods relying on hash are now bounded byT: RlpEcdsaTxwhich works for all of the transactions we have but would likely get trickier for custom signature usecasesSolution
PR Checklist