Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EthereumHardforks + OpHardforks #3

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat: EthereumHardforks + OpHardforks #3

merged 2 commits into from
Jan 9, 2025

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jan 9, 2025

Motivation

Adds hardfork enums from reth

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr requested a review from mattsse as a code owner January 9, 2025 09:49
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

derive_more::FromStr,
derive_more::Display,
)]
pub enum OpHardfork {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep this here for now, but I think eventually we want separate spec crate for op

@mattsse
Copy link
Member

mattsse commented Jan 9, 2025

clippy unrelated, can ignore for now or fix separately

@klkvr klkvr merged commit 0e53125 into main Jan 9, 2025
23 of 27 checks passed
@klkvr klkvr deleted the klkvr/hardforks branch February 1, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants