Skip to content

Commit

Permalink
Update breaking changes doc with a few clarifications (dotnet#39665)
Browse files Browse the repository at this point in the history
  • Loading branch information
stephentoub authored Jul 22, 2019
1 parent 3c3b9ce commit f25b89e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Documentation/coding-guidelines/breaking-change-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Breaking Change Rules
✓ **Allowed**
* Adding an abstract member to a public type when there are _no accessible_ (`public` or `protected`) constructors, or the type is `sealed`

* Moving a member onto a class higher in the hierarchy tree of the type from which it was removed
* Moving a method onto a class higher in the hierarchy tree of the type from which it was removed

* Increasing the visibility of a member that is not `virtual`

Expand All @@ -197,6 +197,8 @@ Breaking Change Rules
This will break existing clients that were bound to the previous overload. For example, if you have a class that has a single version of a method that accepts a `uint`, an existing consumer will
successfully bind to that overload, if simply passing an `int` value. However, if you add an overload that accepts an `int`, recompiling or via late-binding the application will now bind to the new overload. If different behavior results, then this is a breaking change.

* Moving an exposed field onto a class higher in the hierarchy tree of the type from which it was removed

* Removing or renaming a member, including a getter or setter from a property or enum members

* Decreasing the visibility of a `protected` member when there _are accessible_ (`public` or `protected`) constructors and the type is not `sealed`
Expand Down

0 comments on commit f25b89e

Please sign in to comment.