Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for nonroot Docker variant #410

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

kraftner
Copy link
Contributor

Ongoing work to fix #409

Copy link
Contributor

@danielhass danielhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kraftner I think you left out the migration instructions on purpose for now?

I was able to migrate an instance on my side again and it seems that we got all the steps needed as described over in #409.

@almarklein what do you think, shall we maybe move a lot of the details around the Docker-based hosting currently present in this article https://timetagger.app/articles/selfhost2/ over to a "proper" docs page?

README.md Show resolved Hide resolved
deploy/docker-compose.nonroot.yml Outdated Show resolved Hide resolved
Copy link
Owner

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think, shall we maybe move a lot of the details around the Docker-based hosting currently present in this article https://timetagger.app/articles/selfhost2/ over to a "proper" docs page?

Yeah, having a page in the docs with details about the docker images and how to use them sounds like a good plan. Then we can there take the space to explain the difference between root and nonroot, migration, etc. Does not have to be in this PR.

deploy/docker-compose.nonroot.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@kraftner
Copy link
Contributor Author

@danielhass I indeed left out the migration instructions and a more detailed explainer for now since I wanted to talk to you about it first.

I think we now have the bare minimum with an example and a one-liner explaining the difference. One thing that I think would maybe also be nice to tackle at the same time is #411 since that still makes the nonroot variant a bit clunky to use.

Next step could be to either merge this PR or extend it with the bigger documentation rework. What do you think @almarklein?

@kraftner kraftner marked this pull request as ready for review October 16, 2023 09:30
@almarklein almarklein merged commit 45ba173 into almarklein:main Oct 16, 2023
9 checks passed
@almarklein
Copy link
Owner

Awesome!

Next step could be to either merge this PR or extend it with the bigger documentation rework. What do you think @almarklein?

I've merged this PR, since this is now in a good state. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for nonroot Docker variant
3 participants