-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overview scrolling on mobile #427
Conversation
Hey @Tagirijus, this PR should fix both issues you mentioned. As for the the bottom being cut off, I suspect that the phone's navbar obfuscates the app, like this: I allowed the scrolling to pull the overview a bit more upwards, so it should be possible to pull the last bar from under the navbar, so to speak. Could you please try it out at https://staging.timetagger.app/app/demo ? If its good on your end I will merge this PR and also update the actual app. |
Hey, thanks for the update. I just tested with your link: the "more button" with the number on it is not visible on the bottom, but I can at least scroll now. And compared to the desktop version it seems that at least the last task is visible on the bottom then. Not sure if my mobile is a very rare small one these days. Yet I tested with another mobile which has a bigger screen (higher). On that the last task is still a bit cut off. So something is not quite right for now, unfortunately. But at least the scrolling works, yay. Sorry for not having better feedback for now. |
Thanks for trying it out! That's very valuable! Also an interesting problem 😃 BTW is this in a browser or have you "installed" the app (add website to homescreen)? |
It's only in the browser. For "installed" I had to log in, yet I do not have an account. I just tested in hope to be able to see if it might be different, hehe. |
Unfortunately still the same. |
Hold on, nevermind! Had to refresh! Seems to work! |
Ah, great! I read a hint somewhere, and traced it to the change in #194. Good to know that undoing that change fixes it for you. Unfortunately, now it looks like this on iPhone again: I may need to conditionally apply the CSS ... |
Hm, I'd could be ignorant and say: pff, iPhone. d-: ... yet, what a bummer. Maybe a OS depended CSS could be a solution (in case it would even work technically)? |
Yep, still works! Does it fix it on iPhone as well now? Then congratz! (; |
Nope, haha |
This still works on my end. (= |
Yes! And it works for me too! 🥳 Thanks for testing along with me 🙏 |
Nice! I am glad I could help. (= |
* Fix overview scrolling on mobile * Alow wee bit of extra scroll * Reduce wobble when scrolling * try this ... * try this * maybe this? * Add comment * Can remove the extra scrolling then
…v23.11.4@df703a7 (#16171) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/almarklein/timetagger](https://togithub.com/almarklein/timetagger) | patch | `v23.11.2` -> `v23.11.4` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>almarklein/timetagger (ghcr.io/almarklein/timetagger)</summary> ### [`v23.11.4`](https://togithub.com/almarklein/timetagger/releases/tag/v23.11.4) [Compare Source](https://togithub.com/almarklein/timetagger/compare/v23.11.3...v23.11.4) - Fix bug that the total was the taking tag filters into account - [https://github.com/almarklein/timetagger/pull/433](https://togithub.com/almarklein/timetagger/pull/433) - Can unselect tags by clicking on them - [https://github.com/almarklein/timetagger/pull/434](https://togithub.com/almarklein/timetagger/pull/434) ### [`v23.11.3`](https://togithub.com/almarklein/timetagger/releases/tag/v23.11.3) [Compare Source](https://togithub.com/almarklein/timetagger/compare/v23.11.2...v23.11.3) - Fix overview scrolling on mobile by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/427](https://togithub.com/almarklein/timetagger/pull/427) - Tweaks for better experience on mobile by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/428](https://togithub.com/almarklein/timetagger/pull/428) - Fix that selecting recent ds does not replace text by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/429](https://togithub.com/almarklein/timetagger/pull/429) - Report sums rounded durations by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/430](https://togithub.com/almarklein/timetagger/pull/430) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Closes #425
The buttons now respond to a click instead of down, and the overview can be scrolled by dragging.
Also allows to scroll the overview up a bit more, in case the bottom of the app is obscured by a home bar.Fixed that the app takes up the full space, without having a bottom margin on iPhone or the bottom part of the app hidden by the Android navigation bar.This also fixes #194 again, undoing the change in #198 where
100vh
was used instead of100%
. The trick was to removing the padding of the parent element. This post helped me find the solution.