Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent ZkVM host across strata #727

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

prajwolrg
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title Str 1048 native mode panic handling Consistent ZkVM host across strata Mar 11, 2025
@prajwolrg prajwolrg marked this pull request as ready for review March 11, 2025 07:11
@prajwolrg prajwolrg requested review from a team as code owners March 11, 2025 07:11
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 27.86885% with 44 lines in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (0c9741c) to head (b8f1b09).

Files with missing lines Patch % Lines
crates/zkvm/hosts/src/lib.rs 0.00% 12 Missing ⚠️
crates/zkvm/hosts/src/sp1.rs 0.00% 8 Missing ⚠️
bin/prover-client/src/task_tracker.rs 0.00% 7 Missing ⚠️
bin/prover-perf/src/programs/mod.rs 0.00% 7 Missing ⚠️
crates/zkvm/hosts/src/native.rs 0.00% 6 Missing ⚠️
bin/prover-client/src/operators/cl_stf.rs 0.00% 2 Missing ⚠️
bin/prover-client/src/operators/checkpoint.rs 0.00% 1 Missing ⚠️
bin/prover-client/src/operators/operator.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
+ Coverage   54.90%   54.93%   +0.03%     
==========================================
  Files         321      322       +1     
  Lines       35826    35812      -14     
==========================================
+ Hits        19669    19675       +6     
+ Misses      16157    16137      -20     
Files with missing lines Coverage Δ
bin/prover-client/src/main.rs 0.00% <ø> (ø)
bin/prover-perf/src/args.rs 0.00% <ø> (ø)
bin/prover-perf/src/format.rs 0.00% <ø> (ø)
bin/prover-perf/src/github.rs 0.00% <ø> (ø)
bin/prover-perf/src/main.rs 0.00% <ø> (ø)
bin/prover-perf/src/programs/btc_blockscan.rs 85.29% <ø> (ø)
bin/prover-perf/src/programs/checkpoint.rs 74.07% <ø> (ø)
bin/prover-perf/src/programs/cl_stf.rs 85.24% <ø> (ø)
bin/prover-perf/src/programs/evm_ee.rs 80.00% <ø> (ø)
crates/proof-impl/btc-blockspace/src/program.rs 93.75% <100.00%> (+0.41%) ⬆️
... and 12 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Commit: 1c9f420

SP1 Execution Results

program cycles success
Bitcoin Blockspace 70,829
EVM EE STF 296,926
CL STF 174,274
Checkpoint 4,391

@prajwolrg prajwolrg force-pushed the STR-1048-native-mode-panic-handling branch 2 times, most recently from acf7497 to fb9c1f4 Compare March 11, 2025 10:01
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

@storopoli
Copy link
Member

Rebase to get cargo-audit to pass.

@prajwolrg prajwolrg force-pushed the STR-1048-native-mode-panic-handling branch from fb9c1f4 to 521b599 Compare March 11, 2025 16:14
@prajwolrg prajwolrg requested a review from delbonis March 11, 2025 16:37
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b8f1b09

@storopoli storopoli enabled auto-merge March 11, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants