Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-1134: Make Prover's checkpoint submit utilize the retry mechanism. #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Mar 14, 2025

Description

Prover-client: make checkpoint submit utilize the retry mechanism.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich requested review from a team as code owners March 14, 2025 13:25
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (aeda4e4) to head (1ca7c36).

Files with missing lines Patch % Lines
bin/prover-client/src/prover_manager.rs 0.00% 24 Missing ⚠️
bin/prover-client/src/operators/checkpoint.rs 0.00% 4 Missing ⚠️
bin/prover-client/src/operators/operator.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   54.84%   54.79%   -0.06%     
==========================================
  Files         322      322              
  Lines       36207    36221      +14     
==========================================
- Hits        19858    19847      -11     
- Misses      16349    16374      +25     
Files with missing lines Coverage Δ
bin/prover-client/src/operators/operator.rs 0.00% <0.00%> (ø)
bin/prover-client/src/operators/checkpoint.rs 0.00% <0.00%> (ø)
bin/prover-client/src/prover_manager.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Commit: 7e0e08b

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,012
EVM EE STF 302,087
CL STF 166,610
Checkpoint 4,252

@evgenyzdanovich evgenyzdanovich changed the title Prover-client: make checkpoint submit utilize the retry mechanism. STR-1134: Make Prover's checkpoint submit utilize the retry mechanism. Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant