Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-1106: run fn tests in prover strict mode where applicable #739

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Mar 14, 2025

Description

  • Run fn tests in prover strict mode for the Basic Env by default.
  • Hub Network Env is left untouched because it doesn't have the prover service configured (and so running in strict mode is not possible)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich requested a review from a team as a code owner March 14, 2025 17:46
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (aeda4e4) to head (7d63cd3).

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   54.84%   54.82%   -0.02%     
==========================================
  Files         322      322              
  Lines       36207    36207              
==========================================
- Hits        19858    19851       -7     
- Misses      16349    16356       +7     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Commit: 9a1e653

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,012
EVM EE STF 302,087
CL STF 166,610
Checkpoint 4,252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant