Change delete button for routes to delete all routes for page #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasiles
commented
Jan 16, 2025
lfdebrux
reviewed
Jan 16, 2025
hannahkc
reviewed
Jan 16, 2025
thomasiles
force-pushed
the
delete-all-routes
branch
from
65c1554 to
c016d4a
Compare
|
I've moved the delete routes function and added a better test for it. I've also corrected all the dodgy punctuation. I swear I check them every time and every time I get them wrong. |
DavidBiddle
approved these changes
Jan 16, 2025
Add a model and view partial to confirm the deletion of all routes for a page.
Form creators need to be able to delete all the routes for a page, the first route and any secondary skip routes. Add two new routes and controller actions for deleting all the routes for a page. Co-authored-by: Hannah Cooper <[email protected]>
The button on routes#show currently links to journey for deleting a single condition. This commit changes the button to link to the action for deleting all the routes of a page.
thomasiles
force-pushed
the
delete-all-routes
branch
from
c016d4a to
bcf5c35
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let form creators delete all routes for a question
https://trello.com/c/KA2MdRKW/2036-change-delete-routes-button-to-delete-all-routes-for-a-page
https://app.mural.co/t/gaap0347/m/gaap0347/1728478914347/6a7e0b709f50f00f81cab37414fdf44ec8601a70
The delete button on the routes#show page now takes the user to a confirmation screen for removing all the routes associated with the page, not just the primary route.
screenshots