WIP: Spike remove gds sso #769
Conversation
We no longer use this method of authenticating users so can remove the code and tests that enable it.
This Gem was used to support the cddo_sso authentication method and is no longer used.
Remove the Gem, add bits missing from the gem itself.
thomasiles
force-pushed
the
spike-remove-gds-sso
branch
from
b978709 to
d796488
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -85,6 +84,18 @@ def role_changed_to_editor? | |||
| role_changed_to_editor | |||
| end | |||
|
|
|||
| def clear_remotely_signed_out! | |||
| # rubocop:disable Rails/SkipsModelValidations | |||
| update_attribute(:remotely_signed_out, false) | |||
There was a problem hiding this comment.
not sure why update_attribute is used here - maybe to make sure it happens despite the state the user is in?
There was a problem hiding this comment.
I don't think we need the remotely_signed_out! stuff? The existing stuff is reliant on the GOV.UK Signon servers calling an API exposed by gds_sso gem.
| if user_provider == :gds | ||
| gds_sign_out_path | ||
| elsif %i[auth0 cddo_sso mock_gds_sso].include? user_provider | ||
| if %i[auth0 mock_gds_sso].include? user_provider |
There was a problem hiding this comment.
this can be updated
| end | ||
| end | ||
|
|
||
| Warden::Manager.serialize_from_session do |(uid, auth_timestamp)| |
There was a problem hiding this comment.
we could add more tests around these parts lifted from gds_sso
| expect(controller_spy).to have_received :callback_from_omniauth | ||
| end | ||
| # expect(controller_spy).to have_received :callback_from_omniauth | ||
| # end |
There was a problem hiding this comment.
This is a gds_sso specific test which I'm not sure we need
| expect(controller_spy).to have_received :callback_from_omniauth | ||
| end | ||
| # expect(controller_spy).to have_received :callback_from_omniauth | ||
| # end |
There was a problem hiding this comment.
This is a gds_sso specific test which I'm not sure we need
This is a quick spike to look at what the minimum amount of needed to remove the gds sso gem from our application.
It's not complete and not very tested. It works fine but: