Remove the govuk-width-container CSS class from recruitment banner
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `govuk-width-container` is not required, the layout classes from the design system can be added in each application where the govuk_web_banner is used. This will help improve the spacing on mobile and avoid extra spacing to the left and right of the component.
MartinJJones
force-pushed
the
remove-govuk-width-container
branch
from
5c38f97 to
01ee6b2
Compare
MartinJJones
changed the title
govuk-width-container from recruitment bannergovuk-width-container CSS class from recruitment banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
govuk-width-containerCSS class from recruitment bannerWhy
The
govuk-width-containeris not required, the layout classes from the design system can be added in each application where the govuk_web_banner is used.This will help improve the spacing on mobile and avoid extra spacing to the left and right of the component.
https://design-system.service.gov.uk/styles/layout/#common-layouts
Visual Changes
Page: https://www.gov.uk/government/collections/tax-compliance-detailed-information