Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy slides: lazyDistance setting #1340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 29, 2015

Followup to #1338, adding a lazyDistance option.

Ref: #1338 (comment)

@blueyed blueyed mentioned this pull request Jun 29, 2015
@blueyed blueyed changed the title Lazy slides: lazyDistance setting [WIP] Lazy slides: lazyDistance setting Jun 29, 2015
@blueyed blueyed mentioned this pull request Jun 29, 2015
@syd2011
Copy link

syd2011 commented Jun 29, 2015

coool

@blueyed blueyed changed the title [WIP] Lazy slides: lazyDistance setting Lazy slides: lazyDistance setting Jul 15, 2015
@blueyed
Copy link
Contributor Author

blueyed commented Jul 15, 2015

Rebased on master.

@alvarotrigo
What do you think about it?

@alvarotrigo
Copy link
Owner

Looking good!!

Although that's lazy distance for slides.
Ideally lazyDistance will be for both, slides and sections.

Also, consider wrapping all of it in a function. Something like:

destiny = getDestinationsToLazyLoad(destiny);

Oh, and, the condition if( slide.length ) { seems to be there to only deal with the first slide of each section when landing in any slide coming from other vertical section.

Your code should also be applied when moving from slide to slide. So I believe it shouldn't be placed inside that condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants