Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: #4480 scrolling up jumpy behaviour #4539

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AlekseiKrivo
Copy link
Contributor

Hi there!
I faced the same bug as described in issue #4480.
I took the liberty and rewrote the function "beyondFullPageHandler". It looks cleaner now, and I decided to abandon the approach that allowed a user to return to the fullPage container (after normal scrolling) only by accelerating scrolling.

I tried to comment my code clearly but feel free to ask if something is not clear.

Now it scrolls smoothly without any struggle and jumping

fullpagejs.4480.html.mp4

@alvarotrigo
Copy link
Owner

Thanks! I appreciate the PR! 👍
I'll have to test it for some time before considering merging it.

@AlekseiKrivo
Copy link
Contributor Author

Sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants