Rmspe test stat #22
Merged
Rmspe test stat #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add noise transformation that apply perturbations on treatment * Formatting * Add docstring * Fix linting * Add tests to check perturbation impact and randomness over timepoints
| @@ -79,21 +77,6 @@ def to_df(self) -> pd.DataFrame: | |||
| PlaceboSchema.validate(df) | |||
| return df | |||
|
|
|||
| def summary(self, precision: int = 4) -> Table: | |||
There was a problem hiding this comment.
placeholder: I assume this method is migrated elsewhere
There was a problem hiding this comment.
Yes, a new parent class TestResultFrame is created and it owns the summary method. PlaceboTestResult and RMSPETestResult both utilize this method as subclasses.
Co-authored-by: Thomas Pinder <[email protected]>
thomaspinder
added a commit
that referenced
this pull request
Sep 24, 2024
This reverts commit 9b7b5aa.
thomaspinder
added a commit
that referenced
this pull request
Sep 24, 2024
* RMSPE WIP * Rmspe test stat (#22) * Minor change in README to fix guidance for developers (#18) * Noise transform (#19) * Add noise transformation that apply perturbations on treatment * Formatting * Add docstring * Fix linting * Add tests to check perturbation impact and randomness over timepoints * bump version (#20) * Initial implementation of RMSPE * Add TestResultFrame parent class for test results * Add test for RMSPE * Add doc string * Fix linting * Update src/causal_validation/validation/rmspe.py Co-authored-by: Thomas Pinder <[email protected]> * Fix typo --------- Co-authored-by: Thomas Pinder <[email protected]> --------- Co-authored-by: Thomas Pinder <[email protected]> Co-authored-by: Semih Akbayrak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
hatch run dev:formatbefore committing.Description
Issue Number: #16