feat(mockServer): set preserveResolvers default to true #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
packages/parrot-graphql/src/index.js
Outdated
| @@ -14,8 +14,8 @@ | |||
|
|
|||
| const { mockServer } = require('@graphql-tools/mock'); | |||
|
|
|||
| module.exports = function graphql(path, schema, mocks) { | |||
| const server = mockServer(schema, mocks); | |||
| module.exports = function graphql(path, schema, mocks, path, schema, mocks, preserveResolvers = true) { | |||
There was a problem hiding this comment.
you've duplicated function params here
There was a problem hiding this comment.
whelp that was embarrassing :P must have fat fingered something and should have properly setup public github on my work laptop.. updated in code editor this time..
also added an eslint disable for the new forth arg so it's backwards compatible for this small change
Thanks for reviewing Matt!
cchen9299
force-pushed
the
feat/graphql-mock-preserveResolvers
branch
from
7cd7d3d
to
a95d272
Compare
smackfu
approved these changes
Oct 24, 2024
Matthew-Mallimo
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
#253
How Has This Been Tested?
Tested locally with an OneApp module, but I'm unsure whether sharing screenshots of our local development screens in a public github PR breaches any American Express HR violation. I'm on Web and Mobile Slack!
Types of Changes
Checklist:
What is the Impact to Developers Using parrot?