Skip to content

Commit

Permalink
fix: drop yarn (#510)
Browse files Browse the repository at this point in the history
  • Loading branch information
amilajack authored Jan 31, 2022
1 parent dbc6ddd commit 023d0c5
Show file tree
Hide file tree
Showing 5 changed files with 935 additions and 44 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,11 @@ jobs:
node-version: ${{ env.stable-node-version}}
cache: npm

- name: node_modules cache
uses: actions/cache@v2
with:
path: "**/node_modules"
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}

- name: Install dependencies
run: yarn install --frozen-lockfile && yarn add --dev ${{ env.e2e-eslint-version }}
run: npm ci && npm i -D ${{ env.e2e-eslint-version }}

- name: Run tests
run: yarn test && yarn spec:e2e
run: npm test && npm run spec:e2e

- name: Release --dry-run # Uses release.config.js
if: ${{ github.event.inputs.dryRun == 'true'}}
Expand Down
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ Here's a list of tips and tricks that will help you get started.

#### Important Concepts

* Static Analysis
* ASTs
* Polyfills
* TypeScript
* WebIDL
- Static Analysis
- ASTs
- Polyfills
- TypeScript
- WebIDL

### Benchmarking

Benchmarking (`yarn benchmarks`) helps prevent performance regression.
Benchmarking (`npm run benchmarks`) helps prevent performance regression.

#### Related Projects

Expand Down
23 changes: 7 additions & 16 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
variables:
YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
stableNodeVersion: "14.x"
currentNodeVersion: "16.x"
# Used with `eslintVersion` to see if `spec:e2e` and `benchmarks` should run
Expand Down Expand Up @@ -88,27 +87,19 @@ steps:
inputs:
versionSpec: $(nodeVersion)
displayName: Install node@$(nodeVersion)
- task: Cache@2
inputs:
key: 'yarn | "$(Agent.OS)" | yarn.lock'
restoreKeys: |
yarn | "$(Agent.OS)"
yarn
path: $(YARN_CACHE_FOLDER)
displayName: Cache Yarn packages
- script: yarn --frozen-lockfile && yarn add --dev $(eslintVersion) && yarn test
displayName: Install dependencies and run yarn test
- script: npm ci && npm i -D $(eslintVersion) && npm test
displayName: Install dependencies and run npm test
# E2E tests use eslint@7+ only feature (the Node.js API class ESLint)
# Also disabled on windows because of jest snapshot problems
- script: yarn spec:e2e
- script: npm run spec:e2e
condition: and(contains(variables['eslintVersion'], variables['e2eEslintVersion']), ne(variables['imageName'], 'vs2017-win2016'))
displayName: Run yarn spec:e2e if $(eslintVersion) >= $(e2eEslintVersion)
displayName: Run npm run spec:e2e if $(eslintVersion) >= $(e2eEslintVersion)
# Benchmarks use eslint@7_ only feature (the Node.js API class ESLint)
- script: yarn benchmarks
- script: npm run benchmarks
condition: contains(variables['eslintVersion'], variables['e2eEslintVersion'])
displayName: Run yarn benchmarks if $(eslintVersion) >= $(e2eEslintVersion)
displayName: Run npm run benchmarks if $(eslintVersion) >= $(e2eEslintVersion)
# Upload Jest code coverage
- script: yarn spec --coverage --coverageReporters=cobertura
- script: npm run spec --coverage --coverageReporters=cobertura
displayName: Generate Jest coverage report
- task: PublishCodeCoverageResults@1
inputs:
Expand Down
Loading

0 comments on commit 023d0c5

Please sign in to comment.