Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export json related model #837

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Fix export json related model #837

merged 4 commits into from
Oct 23, 2024

Conversation

Vasiliy566
Copy link
Contributor

@aminalaee sorry for that - somehow this commit missed in previous request, require this for nested models - please release it.

@Vasiliy566
Copy link
Contributor Author

previous pr - #829
now it works only for models that dont links to another, this fix allow json export for all models.

@aminalaee
Copy link
Owner

That's ok, but please update the tests so we know the fix is working.

Исаев Василий Сергеевич added 3 commits October 21, 2024 13:34
@Vasiliy566
Copy link
Contributor Author

@aminalaee done

@aminalaee aminalaee changed the title Fix name resolve for nested models. Fix export json related model Oct 23, 2024
aminalaee
aminalaee approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@aminalaee aminalaee merged commit e5e366b into aminalaee:main Oct 23, 2024
5 checks passed
@aminalaee aminalaee mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vasiliy566 @aminalaee