Add KeyedFileMutex #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Sep 25, 2021
kelunik
reviewed
Sep 25, 2021
bwoebi
force-pushed
the
v3-filekeyedmutex
branch
from
42d04dc to
440a5a8
Compare
bwoebi
force-pushed
the
v3-filekeyedmutex
branch
3 times, most recently
from
4672671 to
fa5c47e
Compare
kelunik
reviewed
Feb 8, 2022
trowski
force-pushed
the
v3-filekeyedmutex
branch
from
fa5c47e to
350540c
Compare
kelunik
reviewed
Mar 10, 2024
|
|
||
| return $lock; | ||
| } catch (FilesystemException) { | ||
| delay(self::LATENCY_TIMEOUT); |
There was a problem hiding this comment.
For longer held locks, this is very inefficient. Should we backoff exponentially up to 1 second?
There was a problem hiding this comment.
Probably a good idea. This is exactly what we're doing for FileMutex as well, so I'd say let's update both then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.