Update for latest Psalm

amphp · Jan 28, 2024 · 466b5dc · 466b5dc
1 parent 6c711ee
commit 466b5dc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/src/Internal/Posix/PosixHandle.php b/src/Internal/Posix/PosixHandle.php
@@ -51,7 +51,9 @@ static function (string $callbackId, $stream) use (&$status, $deferred, $stdin,
                 // Don't call proc_close here or close output streams, as there might still be stream reads
                 $stdin->get()?->close();
 
-                \fclose($stream);
+                if (\is_resource($stream)) {
+                    \fclose($stream);
+                }
 
                 self::asyncWaitPid($shellPid);
             },

diff --git a/src/Internal/Posix/PosixRunner.php b/src/Internal/Posix/PosixRunner.php
@@ -109,6 +109,7 @@ static function (CancelledException $e) use ($suspension, $callbackId): void {
             $cancellation->unsubscribe($cancellationId);
         }
 
+        /** @psalm-suppress RiskyTruthyFalsyComparison */
         $pid = \rtrim(\fgets($extraDataPipe) ?: '');
         if (!$pid || !\is_numeric($pid)) {
             \proc_terminate($proc);

diff --git a/src/Internal/Windows/WindowsRunner.php b/src/Internal/Windows/WindowsRunner.php
@@ -61,6 +61,7 @@ public function start(
         });
 
         try {
+            /** @psalm-suppress RiskyTruthyFalsyComparison */
             $proc = \proc_open(
                 $this->makeCommand($workingDirectory ?? ''),
                 self::FD_SPEC,
@@ -113,6 +114,7 @@ public function start(
 
             $cancellation->throwIfRequested();
 
+            /** @psalm-suppress RiskyTruthyFalsyComparison */
             throw new ProcessException(\trim($message ?: 'Process did not connect to server before timeout elapsed'));
         }
 

diff --git a/src/Process.php b/src/Process.php
@@ -62,7 +62,7 @@ public static function start(
             ? \implode(" ", \array_map(escapeArgument(...), $command))
             : $command;
 
-        if (!$workingDirectory) {
+        if ($workingDirectory === null) {
             $cwd = \getcwd();
             if ($cwd === false) {
                 throw new ProcessException('Failed to determine current working directory');