Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type for RedistList::get() #96

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Jul 28, 2024

This fixes a bug that caused the following exception to be thrown when the list key did not exist:

TypeError : Amp\Redis\Command\RedisList::get(): Return value must be of type string, null returned

As a bonus, we expanded the allowed types for RedistList::get to include integer, which is probably the type it should have always been. We don't replace string at this time, though, for BC reasons.

Expanded allowed types for RedistList::get to include integer.
@trowski trowski merged commit a1e8cdc into amphp:2.x Aug 3, 2024
0 of 2 checks passed
@trowski
Copy link
Member

trowski commented Aug 3, 2024

Thanks!

@Bilge Bilge deleted the fix-list-get branch August 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants