Drop error suppression

amphp · Jun 25, 2020 · b9064b9 · b9064b9
1 parent 75321ab
commit b9064b9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/DatagramSocket.php b/src/DatagramSocket.php
@@ -162,7 +162,7 @@ public function send(SocketAddress $address, string $data): Promise
                     throw new SocketException(\sprintf('Could not send packet on endpoint: %s', $errstr));
                 });
 
-                $result = @\stream_socket_sendto($this->socket, $data, 0, $address->toString());
+                $result = \stream_socket_sendto($this->socket, $data, 0, $address->toString());
                 /** @psalm-suppress TypeDoesNotContainType */
                 if ($result < 0 || $result === false) {
                     throw new SocketException('Could not send packet on endpoint: Unknown error');

diff --git a/src/Internal/functions.php b/src/Internal/functions.php
@@ -92,7 +92,7 @@ function setupTls($socket, array $options, ?CancellationToken $cancellationToken
             new TlsException('TLS negotiation failed: ' . $errstr);
         });
 
-        $result = @\stream_socket_enable_crypto($socket, $enable = true);
+        $result = \stream_socket_enable_crypto($socket, $enable = true);
         if ($result === false) {
             throw new TlsException('TLS negotiation failed: Unknown error');
         }
@@ -134,7 +134,7 @@ function setupTls($socket, array $options, ?CancellationToken $cancellationToken
                         throw new TlsException('TLS negotiation failed: ' . $errstr);
                     });
 
-                    $result = @\stream_socket_enable_crypto($socket, true);
+                    $result = \stream_socket_enable_crypto($socket, true);
                     if ($result === false) {
                         $message = \feof($socket) ? 'Connection reset by peer' : 'Unknown error';
                         throw new TlsException('TLS negotiation failed: ' . $message);

diff --git a/src/functions.php b/src/functions.php
@@ -83,7 +83,7 @@ function createPair(): array
             throw new SocketException(\sprintf('Failed to create socket pair.  Errno: %d; %s', $errno, $errstr));
         });
 
-        $sockets = @\stream_socket_pair(\stripos(PHP_OS, 'win') === 0 ? STREAM_PF_INET : STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP);
+        $sockets = \stream_socket_pair(\stripos(PHP_OS, 'win') === 0 ? STREAM_PF_INET : STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP);
         if ($sockets === false) {
             throw new SocketException('Failed to create socket pair.');
         }