refactor(google-maps): tree-shake assertInitialized
#30813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
requested review from
crisbeto and
andrewseguin
and removed request for
a team
Prior to this commit, in production bundles, `assertInitialized` is an empty method (its body is guarded with `ngDevMode`) that is preserved on the class and always called. There's no reason to keep calling no-op methods in production. This also increases bundle size because the method itself is not tree-shaken. In this commit, the assertion has been moved to a separate function, which can be dropped in production due to the `ngDevMode` guard. The only downside I couldn't resolve is that assertion functions (`asserts ...`) can't be used in this setup, so I had to use the non-null assertion operator instead.
arturovt
force-pushed
the
refactor/google-maps-tree-shake
branch
from
5bd21a9 to
e609ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, in production bundles,
assertInitializedis an empty method (its body is guarded withngDevMode) that is preserved on the class and always called. There's no reason to keep calling no-op methods in production. This also increases bundle size because the method itself is not tree-shaken.In this commit, the assertion has been moved to a separate function, which can be dropped in production due to the
ngDevModeguard.The only downside I couldn't resolve is that assertion functions (
asserts ...) can't be used in this setup, so I had to use the non-null assertion operator instead.