Remove noImplicitUseStrict usage in tests

The options is deprecated and is going to be removed in TypeScript. tsickle's googmodule transformer already removes "use strict", so this option has no effect. __awaiter change: The first argument is `thisArg`. It's `this` if there is a lexical this in scope, which changes based on strict mode. Tsickle output is expected to be bundled with Closure Compiler, which assumes strict mode, so `noImplicitUseStrict` should generally be turned off. PiperOrigin-RevId: 541810412
angular · Jul 12, 2023 · d391580 · d391580
1 parent ff2a726
commit d391580
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/test/googmodule_test.ts b/test/googmodule_test.ts
@@ -518,7 +518,7 @@ describe('convertCommonJsToGoogModule', () => {
         goog.module('project.file');
         var module = module || { id: 'project/file.ts' };
         const tslib_1 = goog.require('tslib');
-        (() => tslib_1.__awaiter(this, void 0, void 0, function* () {
+        (() => tslib_1.__awaiter(void 0, void 0, void 0, function* () {
             const starImport = yield goog.requireDynamic('project.relpath');
         }))();
       `).split(/\n/g));
@@ -539,9 +539,8 @@ describe('convertCommonJsToGoogModule', () => {
       expect(beforeLines).toEqual(outdent(`
         goog.module('project.file');
         var module = module || { id: 'project/file.ts' };
-        var _this = this;
         var tslib_1 = goog.require('tslib');
-        (function () { return tslib_1.__awaiter(_this, void 0, void 0, function () {
+        (function () { return tslib_1.__awaiter(void 0, void 0, void 0, function () {
             var starImport;
             return tslib_1.__generator(this, function (_a) {
                 switch (_a.label) {
@@ -571,7 +570,7 @@ describe('convertCommonJsToGoogModule', () => {
         goog.module('project.file');
         var module = module || { id: 'project/file.ts' };
         const tslib_1 = goog.require('tslib');
-        (() => tslib_1.__awaiter(this, void 0, void 0, function* () {
+        (() => tslib_1.__awaiter(void 0, void 0, void 0, function* () {
             const { Foo } = yield goog.requireDynamic('project.relpath');
         }))();
       `).split(/\n/g));
@@ -592,9 +591,8 @@ describe('convertCommonJsToGoogModule', () => {
       expect(beforeLines).toEqual(outdent(`
         goog.module('project.file');
         var module = module || { id: 'project/file.ts' };
-        var _this = this;
         var tslib_1 = goog.require('tslib');
-        (function () { return tslib_1.__awaiter(_this, void 0, void 0, function () {
+        (function () { return tslib_1.__awaiter(void 0, void 0, void 0, function () {
             var Foo;
             return tslib_1.__generator(this, function (_a) {
                 switch (_a.label) {

diff --git a/test/test_support.ts b/test/test_support.ts
@@ -76,7 +76,6 @@ export const baseCompilerOptions: ts.CompilerOptions = {
   experimentalDecorators: true,
   module: ts.ModuleKind.CommonJS,
   strictNullChecks: true,
-  noImplicitUseStrict: true,
   allowJs: false,
   importHelpers: true,
   noEmitHelpers: true,

diff --git a/test_files/async_functions/async_functions.js b/test_files/async_functions/async_functions.js
@@ -42,7 +42,7 @@ const asyncTopLevelArrowFunction = (/**
  * @param {string} param
  * @return {!Promise<number>}
  */
-(param) => tslib_1.__awaiter(this, void 0, void 0, function* () {
+(param) => tslib_1.__awaiter(void 0, void 0, void 0, function* () {
     /** @type {number} */
     const s = yield 3;
     return s;
@@ -122,12 +122,12 @@ if (false) {
 const asyncArrowFn = (/**
  * @return {!Promise<void>}
  */
-() => tslib_1.__awaiter(this, void 0, void 0, function* () { }));
+() => tslib_1.__awaiter(void 0, void 0, void 0, function* () { }));
 /** @type {function(): !Promise<void>} */
 exports.exportedAsyncArrowFn = (/**
  * @return {!Promise<void>}
  */
-() => tslib_1.__awaiter(this, void 0, void 0, function* () { }));
+() => tslib_1.__awaiter(void 0, void 0, void 0, function* () { }));
 /**
  * @return {function(): !Promise<number>}
  * @this {*}