Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly transpile exported array destructuring. #1501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 11, 2024

Properly transpile exported array destructuring.

Before, it was missing a variable declaration after traspilation for identifiers used in alias assignment expressions. The cause was missing exports on actual identifiers that needed import, and ended up getting removed by the passes coming aftewards, because jsdoc_transformer was renaming identifiers destructuring statements, but not the usage of those identifiers properly because exported symbol ends up being used as exports.identifier_destructured, but it was being used as identifier_destructured pattern.

Before, it was missing a variable declaration after traspilation for identifiers used in alias assignment expressions. The cause was missing exports on actual identifiers that needed import, and ended up getting removed by the passes coming aftewards, because jsdoc_transformer was renaming identifiers destructuring statements, but not the usage of those identifiers properly because exported symbol ends up being used as `exports.identifier_destructured`, but it was being used as `identifier_destructured` pattern.

PiperOrigin-RevId: 597281499
@copybara-service copybara-service bot changed the title Properly transpile array destructuring pattern in the highest level. Properly transpile exported array destructuring. Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants